Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Raspberry Pi 3 device tree list #3301

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

agners
Copy link
Member

@agners agners commented Apr 11, 2024

Make sure all Raspberry Pi devices using the BCM2837 SoC (or the SiP version RP3A0 of it) are deployed. This especially makes sure that we only deploy the downstream device trees (named bcm2710*) and deploy device trees for the CM3 as well as the Zero 2 and Zero 2 W consistently for 32-bit and 64-bit.

Fixes: #3298

Copy link
Member

@sairon sairon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs rebase after RPi kernel bump to 6.6 😬

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft April 11, 2024 07:41
Make sure all Raspberry Pi devices using the BCM2837 SoC (or the SiP
version RP3A0 of it) are deployed. This especially makes sure that
we only deploy the downstream device trees (named bcm2710*) and deploy
device trees for the CM3 as well as the Zero 2 and Zero 2 W consistently
for 32-bit and 64-bit.
@agners agners force-pushed the streamline-rpi3-device-trees branch from 3ff9fe2 to d0ebfb4 Compare April 11, 2024 07:45
@agners
Copy link
Member Author

agners commented Apr 11, 2024

This needs rebase after RPi kernel bump to 6.6 😬

Right! Rebased!

@agners agners marked this pull request as ready for review April 11, 2024 07:56
@home-assistant home-assistant bot requested a review from sairon April 11, 2024 07:56
Copy link
Member

@sairon sairon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Seems that the broadcom/bcm2837-rpi-3-b wasn't needed, it's the upstream DT with some downstream parts missing. Unless it was picked by FW in some cases (which IMHO doesn't make much sense) it should be safe to remove it.

@agners
Copy link
Member Author

agners commented Apr 12, 2024

Looks good. Seems that the broadcom/bcm2837-rpi-3-b wasn't needed, it's the upstream DT with some downstream parts missing. Unless it was picked by FW in some cases (which IMHO doesn't make much sense) it should be safe to remove it.

I've just checked on a Raspberry Pi 3 (non-plus), and it doesn't seem to get picked today (/proc/device-tree/wifi-pwrseq which is specific to the upstream device tree is not present).

@agners agners merged commit 4f53947 into dev Apr 12, 2024
2 checks passed
@agners agners deleted the streamline-rpi3-device-trees branch April 12, 2024 07:42
@fabfix
Copy link

fabfix commented Apr 12, 2024

Hi @agners, thank you soo much for the fast resolution!
Do you know in witch release this fix will available?

jens-maus added a commit to jens-maus/RaspberryMatic that referenced this pull request Apr 13, 2024
@sairon sairon added the board/raspberrypi Raspberry Pi Boards label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raspberry CM3+
3 participants